Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scenario.yaml results for nightly tests #689

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Jan 30, 2023

This PR updates nightly test expected values.

It contains a subset of the changes in #669, supersedes #688, and closes #671.

How to review

Per #688 (comment):

  1. Push a commit temporarily enabling these lines:
    # Uncomment these two lines for debugging, but leave them commented on 'main'
    # pull_request:
    # branches: [ main ]
  2. Follow the resulting "nightly" run.
  3. Once it passes, confirming the new values:
    • Approve.
    • Force-push the branch to drop the temporary commit. (This can also be done by pushing a second commit that comments the 2 lines again, if the branch is to be squash-merged.)
    • Merge.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅
  • [ ] Add, expand, or update documentation. N/A; CI changes only.
  • [ ] Update release notes.

@khaeru khaeru added the ci Continuous integration label Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #689 (04afc14) into main (8e701a4) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #689   +/-   ##
=====================================
  Coverage   93.5%   93.5%           
=====================================
  Files         44      44           
  Lines       3514    3514           
=====================================
  Hits        3286    3286           
  Misses       228     228           

@khaeru
Copy link
Member Author

khaeru commented Jan 30, 2023

https://github.com/iiasa/message_ix/actions/runs/4044981970/jobs/6955825538#step:10:6901 passed:

=========================== short test summary info ============================
PASSED message_ix/tests/test_nightly.py::test_scenario[CD_Links_SSP2_baseline]
PASSED message_ix/tests/test_nightly.py::test_scenario[CD_Links_SSP2_v2_1000]
=========== 2 passed, 157 deselected, 1 warning in 730.32s (0:12:10) ===========

@khaeru khaeru self-assigned this Jan 30, 2023
@khaeru khaeru force-pushed the update-nightly-scenario-yaml branch from 04afc14 to 61b8d16 Compare January 30, 2023 15:00
@khaeru khaeru merged commit 9c71ff4 into main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust failing nightly tests for #653
3 participants