Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scenario.yaml results for nightly tests #688

Closed
wants to merge 2 commits into from

Conversation

gidden
Copy link
Member

@gidden gidden commented Jan 20, 2023

This PR updates nightly test expected values.

It contains a subset of the changes in #669, and closes #671.

How to review

  • Try local execution

PR checklist

  • Continuous integration checks all ✅

- [ ] Add or expand tests; coverage checks both ✅
- [ ] Add, expand, or update documentation.
- [ ] Update release notes.

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #688 (ec1c0e8) into main (8e701a4) will not change coverage.
The diff coverage is n/a.

❗ Current head ec1c0e8 differs from pull request most recent head 04afc14. Consider uploading reports for the commit 04afc14 to get more accurate results

@@          Coverage Diff          @@
##            main    #688   +/-   ##
=====================================
  Coverage   93.5%   93.5%           
=====================================
  Files         44      44           
  Lines       3514    3514           
=====================================
  Hits        3286    3286           
  Misses       228     228           

@khaeru khaeru changed the title update scenario.yaml results for nightly tests Update scenario.yaml results for nightly tests Jan 30, 2023
@khaeru khaeru added the ci Continuous integration label Jan 30, 2023
@khaeru khaeru self-assigned this Jan 30, 2023
@khaeru khaeru force-pushed the update-nightly-scenario-yaml branch from ec1c0e8 to 04afc14 Compare January 30, 2023 14:36
@khaeru
Copy link
Member

khaeru commented Jan 30, 2023

I pushed a commit temporarily enabling these lines:

# Uncomment these two lines for debugging, but leave them commented on 'main'
# pull_request:
# branches: [ main ]

Here is the resulting check run.

Once this passes, confirming the new values, I will:

  • Approve.
  • Force-push the branch to drop the temporary commit. (This can also be done by pushing a second commit that comments the 2 lines again, if the branch is to be squash-merged.)
  • Merge.

@khaeru
Copy link
Member

khaeru commented Jan 30, 2023

Once this passes,

Sorry, didn't notice earlier: this can never pass. The "nightly" workflow uses a HTTPS username/password stored as GitHub "secrets" to download the input data for the nightly tests. This current PR is from a fork, and GHA runs from forks aren't given access to such secrets (for security reasons).

The PR should be made from a branch in the main repo → #689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust failing nightly tests for #653
2 participants