Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous client #8

Open
FireMasterK opened this issue Feb 29, 2024 · 4 comments
Open

Asynchronous client #8

FireMasterK opened this issue Feb 29, 2024 · 4 comments

Comments

@FireMasterK
Copy link
Collaborator

Currently, the client is synchronous as seen in https://github.com/iggy-rs/iggy-python-client/blob/main/src/client.rs

Are there any plans for an asynchronous client, for use with libraries such as asyncio?

@bartoszkobylinski
Copy link
Collaborator

Just a heads-up, if you check "python_examples" file, you'll notice we're already using asyncio. It fits like a glove since irrys is all about that async life naturally. Thought you'd like to know!

@FireMasterK
Copy link
Collaborator Author

True, I noticed that earlier too, but the actual functions aren't defined as async, if I understand correctly the thread from python is blocked on the tokio runtime task.

@hubcio
Copy link
Collaborator

hubcio commented Mar 2, 2024

True, I noticed that earlier too, but the actual functions aren't defined as async, if I understand correctly the thread from python is blocked on the tokio runtime task.

hello! i'm not python expert - could you please propose PR how to fix this?

@hubcio
Copy link
Collaborator

hubcio commented Mar 2, 2024

@FireMasterK I asked chatgpt about this:
https://chat.openai.com/share/b102601e-6673-4315-9a95-cdae8ef4ed86

does it sounds reasonable to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants