Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loosen the package version for torch 2.0 #74

Open
imliuruiqi opened this issue Apr 27, 2023 · 4 comments
Open

loosen the package version for torch 2.0 #74

imliuruiqi opened this issue Apr 27, 2023 · 4 comments

Comments

@imliuruiqi
Copy link
Contributor

When installing this package through pip install clip-video-encode , it can be observed that the package is compatible with pytorch 2.0 as

clip-video-encode 1.3.0 depends on torch<2 and >=1.7.1
@iejMac
Copy link
Owner

iejMac commented Apr 27, 2023

@imliuruiqi yeah sounds good. I'm super busy these days, if you could submit a PR I'd be happy to merge it

@imliuruiqi
Copy link
Contributor Author

I check the setup.py and it seems that it will get the the install_requires from requirements.txt and it turns out that the torch version is fine:

torch>=1.7.1,<=2

maybe you just need to release a new version with the current requirements

@iejMac
Copy link
Owner

iejMac commented Apr 27, 2023

ah yeah, I'm planning on doing a release soon, in the mean time you can just git clone and pip install -e .

@imliuruiqi
Copy link
Contributor Author

unfortunately, I was unable to install it by that way, got error with ERROR: Failed building wheel for pyarrow mainly blames to the cmake. But nevermind i will wait the release as i am not in a hurry.
Thanks a lot for your time and take care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants