fix(logging): make the verbosity option more eager #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the verbosity option is handled before the configs are loaded so the logger level is set to the user's value in the config code.
|
This could be a solution but I have not tested it fully. There seems to be some weird behavior when the verbosity option is not specified. |
|
The config option and parameter are also set as "eager" so I don't know if the verbosity option will be the first to be handled in all cases. |
|
Amazing work, thx! Does this require any change on the current setup? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the verbosity option is handled before the configs are loaded so the logger level is set to the user's value in the config code.
Fixes #5.