Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The javascript prover and verifier will succeed when using public inputs > field prime #436

Open
norswap opened this issue Oct 15, 2023 · 1 comment

Comments

@norswap
Copy link

norswap commented Oct 15, 2023

I ran into this issue with one of my circuits where the proof was successfully generating locally, and the local verifier would successfully verify the proof, but the Solidity verifier would reject the proof, even though the public signals and proof were identical.

I was using random values sampled from [0, 2^256] instead of bounding them to the field prime (one was a public signal, and the other a private signal).

I reckon both the prover and the verifier should fail early if any of the signal are larger than the field prime.

@ytrezq
Copy link

ytrezq commented Sep 21, 2024

@norswap the issue was fixed some months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants