Document boolean constraint requirement for gates. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
pushed a commit
to piotr-roslaniec/circomlib
that referenced
this pull request
Sep 18, 2024
New primes and custom gates added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users might naturally assume that they can use gates with non binary inputs. For example, you might assume that
Orof two non zero numbers is non zero, or perhaps1. In fact it is not tightly constrained, and can even be0ifa = 2andb = 2.This documents which circuits don't extend to non binary inputs, and gives a specific example of why not.