Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounds check non-strict Num2Bits and Bits2Nums #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bounds check non-strict Num2Bits and Bits2Nums #69

wants to merge 3 commits into from

Commits on Mar 29, 2022

  1. Bounds check non-strict Num2Bits and Bits2Nums 

    Num2Bits is not well defined with n > 253 and could lead to aliasing; disallow these sizes, as they are almost always mistakes. Users who intend to explicitly handle aliasing can write their own circuit.

If the highest bit is required, Num2Bits_strict performs a 254-bit decomposition and includes an alias check.
    @ecnerwala
    ecnerwala authored Mar 29, 2022
    Configuration menu
    Copy the full SHA
    b01f5ad View commit details
    Browse the repository at this point in the history

  2. Don't need include

    @ecnerwala
    ecnerwala committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    8e77e25 View commit details
    Browse the repository at this point in the history

  3. Use Num2Bits_strict in pointbits

    @ecnerwala
    ecnerwala committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    51488df View commit details
    Browse the repository at this point in the history