Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should nWindowsPerSegment be 62？ #12

Open
zyfrank opened this issue May 31, 2019 · 2 comments
Open

should nWindowsPerSegment be 62？ #12

zyfrank opened this issue May 31, 2019 · 2 comments

Comments

@zyfrank
Copy link

zyfrank commented May 31, 2019

circomlib/src/pedersenHash.js

Line 8 in d91afa8

const nWindowsPerSegment = 50;

@HarryR
Copy link

HarryR commented Jul 4, 2019

Agreed, this should be 62.
See: HarryR/ethsnarks#121

@jbaylina
Copy link
Member

jbaylina commented Sep 5, 2019

In this version, I'm using a window size of 4 instead of 3. But it's better with 3 so this needs to be moved.

piotr-roslaniec pushed a commit to piotr-roslaniec/circomlib that referenced this issue Sep 18, 2024
@alrubio
Merge pull request iden3#12 from fluidex/master
76cae55 
macos (x86_64) support for cpp backend;  use template to generate makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HarryR @jbaylina @zyfrank