Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use a custom normalize_path to resolve duplicate symbol problem #46

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phated
Copy link
Contributor

@phated phated commented Apr 21, 2022

This PR helps to better support rust->wasm compilation of the circom compiler. I believe the wasm target doesn't support std::fs::canonicalize but @antimatter15 can probably provide more context on his change.

This is currently a draft because I want to discuss how we can handle the "file existence" check that std::fs::canonicalize was providing. Is there a better way or place to check for file existence that will work in rust & wasm?

@phated
Copy link
Contributor Author

phated commented Apr 21, 2022

Ref https://github.com/rust-lang/rust/blob/734368a200904ef9c21db86c595dc04263c87be0/library/std/src/sys/wasi/fs.rs#L622

We could probably re-implement it ourselves using other APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant