AST to JSON serialization support #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added --save_ast flag
Now it's possible to specify default file path/name for the serialized AST file output
When --dry-run is specified, it will only run check and output serialized AST, but not compile
Removed default value. Hint improved.
Co-authored-by: Artem Chystiakov <[email protected]>
Fix save_ast required a value, despite being optional. Change path handling logic in save_ast to output into the given output path
feat: Add AST serialization and exporting support
…/arm-ci # Conflicts: # circom/src/parser_user.rs # parser/src/lib.rs # parser/src/parser_logic.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented AST to JSON serialization to allow third-party language analysis tools to be built. This will allow binding generators, static analyzers, and probably even linters to enter the ZK game.
We have added several cli arguments:
--save_ast <ast_path>to save the serialized AST to<ast_path>_ast.jsonfile.--dry_runto quit the compilation process right after parsing the circom file.Running these two commands together will save time producing the JSONs on larger projects.
Would appreciate the feedback!