Fix Crossplatform mapping for Windows

[groscoe2]

When reading through the Crossplatform value mapping for Windows, I noticed that 20, 40, 60, and 80 were within the valid range of [0,99], but were not covered by the match statement. This PR updates the thread priority ranges to include each of these values as appropriate and also adds a test case for Crossplatform value 80. The ranges were adjusted to keep the Crossplatform values distributed as even as possible across the Windows thread priority values.

Summary by CodeRabbit

• Refactor
  • Improved the mapping of thread priorities to enhance application performance on Windows platforms.
• Tests
  • Added a new test case for verifying the correct assignment of the highest thread priority on Windows.

[coderabbitai]

Walkthrough

This update fine-tunes the mapping between cross-platform ThreadPriority values and their corresponding WinAPIThreadPriority enums, ensuring a more precise alignment with Windows API priority levels. Additionally, it introduces a test case to verify the correct assignment of the highest priority level for a specific thread priority setting, enhancing the robustness of priority management across different operating systems.

Changes

File Path	Change Summary
src/windows.rs	Adjusted mapping of ThreadPriority to WinAPIThreadPriority, shifting priority ranges by 1.
tests/windows.rs	Added test for setting cross-platform thread priority to 80u8, mapping to highest Windows priority.

🐇🎉
To code, to build, a change we weave,
Through lines of logic, in threads we believe.
A shift, a tweak, in priority’s dance,
Ensuring every thread gets its chance.
So hop and leap, let’s celebrate,
For our code’s more robust, and that’s truly great!
🎈🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 74cf570 and 0f6b37a.

Files selected for processing (2)

• src/windows.rs (1 hunks)
• tests/windows.rs (1 hunks)

Additional comments: 2

tests/windows.rs (1)

• 9-9: The addition of a new test case for a cross-platform value of 80 mapping to WinAPIThreadPriority::Highest is a good practice to validate the changes made in the mapping logic. It ensures that the new value is correctly handled and mapped, enhancing the test coverage for the priority mapping functionality.

src/windows.rs (1)

• 80-83: The adjustments made to the priority ranges in the TryFrom<ThreadPriority> for WinAPIThreadPriority implementation correctly account for the previously missing values (20, 40, 60, and 80) by shifting the ranges for BelowNormal, Normal, AboveNormal, and Highest priorities. This change ensures a more comprehensive and evenly distributed mapping across Windows thread priority values, aligning with the PR objectives.

[iddm]

Thank you for finding this :)