-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make version info more reliable for git archive #577
Open
MicahGale
wants to merge
16
commits into
develop
Choose a base branch
from
576-make-version-info-more-reliable-for-git-archive
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
make version info more reliable for git archive #577
MicahGale
wants to merge
16
commits into
develop
from
576-make-version-info-more-reliable-for-git-archive
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typos -_-
fix typo
MicahGale
added
CI/CD
code improvement
A feature request that will improve the software and its maintainability, but be invisible to users.
labels
Oct 20, 2024
MicahGale
changed the title
576 make version info more reliable for git archive
make version info more reliable for git archive
Oct 20, 2024
Will do a squash commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/CD
code improvement
A feature request that will improve the software and its maintainability, but be invisible to users.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it so that
git archive
includes the information necessary forsetuptools_scm
to get a version number. This is based on this guide. Also added a test to make sure this works.Fixes #576
Checklist