Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VisualBasic.Chr method recognition #1031

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

TymurGubayev
Copy link
Contributor

Fixes #1030

Problem

Any method called Chr was treated as if it was Microsoft.VisualBasic.Chr.

Solution

  • Add a test case for custom methods called Chr and ChrW
  • Move the check for Chr and ChrW in a separate method
  • Adjust the check to not have false-positive result
  • Also, in IsCultureInvariant remove the symbol name check as redundant

@GrahamTheCoder GrahamTheCoder merged commit 45e0128 into icsharpcode:master Sep 20, 2023
2 checks passed
@GrahamTheCoder
Copy link
Member

Thanks for this, and sorry it took me so long to get it merged!

@TymurGubayev TymurGubayev deleted the TymurGubayev-patch-1 branch October 4, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VB -> C#: own Chr method invocations are lost with terrible consequences
2 participants