Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo for docker files and starter kits #25

Open
Vlad-Shcherbina opened this issue Jul 1, 2020 · 1 comment
Open

Monorepo for docker files and starter kits #25

Vlad-Shcherbina opened this issue Jul 1, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@Vlad-Shcherbina
Copy link

As you can see, pull requests often come in pairs: one to dockerfiles and one to whatever-starter-kit. It should be one atomic change. Furthermore, it's inconvenient for contributors to propose new platforms without you creating a new empty starter kit repo first.

Consider merging all this stuff into a monorepo.

It will make getting started a bit harder (one can't just clone favorite-language-starter-kit, has to copy a sub-directory), but I think it's worth it.

@beevee beevee added the enhancement New feature or request label Jul 1, 2020
@beevee
Copy link
Member

beevee commented Jul 1, 2020

It makes sense, but our current process more closely resembles actual contest situation: separate repository that contains team solution, separate repository that contains Dockerfiles. We have an internal CI that continuosly checks all starterkits against current Dockerfiles, so I can make sure everything works.

Your suggestion is valid though. I'll give it a thought.

@beevee beevee mentioned this issue Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants