Merge pull request #10 from ice-lab/emptyAssets-before-unmount

Empty assets before unmount
ice-lab · Aug 20, 2019 · 8b236df · 8b236df
2 parents 3305ded + 1782eca
commit 8b236df
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ice/stark",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Icestark is a JavaScript library for multiple react projects, Ice workbench solution.",
   "scripts": {
     "build": "rm -rf lib && tsc",
@@ -39,15 +39,13 @@
     "react-dom": ">=15.0.0"
   },
   "dependencies": {
-    "history": "^4.6.1",
     "path-to-regexp": "^1.7.0",
     "url-parse": "^1.1.9"
   },
   "devDependencies": {
     "@commitlint/cli": "^7.5.2",
     "@commitlint/config-conventional": "^7.5.0",
     "@ice/spec": "^0.1.4",
-    "@types/history": "^4.7.0",
     "@types/jest": "^24.0.12",
     "@types/node": "^12.0.0",
     "@types/path-to-regexp": "^1.7.0",

diff --git a/src/AppRoute.tsx b/src/AppRoute.tsx
@@ -70,6 +70,9 @@ export default class AppRoute extends React.Component<AppRouteProps, AppRouteSta
   }
 
   componentWillUnmount() {
+    // Empty useless assets before unmount
+    const { useShadow } = this.props;
+    emptyAssets(useShadow);
     this.unmounted = true;
     setIcestark('root', null);
   }