Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error as event as well #48

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Throw error as event as well #48

wants to merge 3 commits into from

Conversation

sudipghimire533
Copy link
Collaborator

While throwing error from extrinsic, also deposit error as event.

  • Every error is of type frame_system::Error i.e airdrop pallet can throw error other that it's own pallet error eg: Overflow, AmountTooLow
  • Error of origin check is not stored as event, it might leave a room to hog the storage with unsigned call multiple time

@sudipghimire533 sudipghimire533 changed the title Sg/error as event Throw error as event as well Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrizsabin ibrizsabin Awaiting requested review from ibrizsabin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sudipghimire533