You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Return a Task or don't return until NTP has stopped so the GUI doesn't have to have a 20 second timeout
When time mode is initially set to Manual from NTP,
NTP service is disabled and the NTP service is
stopping but not stopped, setting time will return an error.
There are no responses from backend to notify when NTP is stopped.
Regarding this issue, I pushed a new patch: https://gerrit.openbmc.org/c/openbmc/phosphor-time-manager/+/56584
And Looks like the maintiner is against adding this feature to the timeManager repo, because he think that this logic should be handled where it is called.
But we still did some refactoring to the timeManager repo。
Return a Task or don't return until NTP has stopped so the GUI doesn't have to have a 20 second timeout
When time mode is initially set to Manual from NTP,
NTP service is disabled and the NTP service is
stopping but not stopped, setting time will return an error.
There are no responses from backend to notify when NTP is stopped.
Date-time bug openbmc/openbmc#3459
https://ibm-systems-power.slack.com/archives/C0Q6TQP5Z/p1616420134178500
Looking to get rid of the 20 sec timeout on the GUI here:
https://github.com/openbmc/webui-vue/blob/master/src/store/modules/Settings/DateTimeStore.js#L49
To do that need to not return until NTP stops or return a task the client (GUI) can watch
I suspect we need some changes here: https://github.com/openbmc/phosphor-time-manager
The text was updated successfully, but these errors were encountered: