Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Task / Don't return until NTP stops #3370

Open
gtmills opened this issue Oct 18, 2021 · 4 comments
Open

Return Task / Don't return until NTP stops #3370

gtmills opened this issue Oct 18, 2021 · 4 comments
Assignees
Labels
Migrate-No Do not migrate to Jira ReadyForDev Stories ready for development work
Milestone

Comments

@gtmills
Copy link

gtmills commented Oct 18, 2021

Return a Task or don't return until NTP has stopped so the GUI doesn't have to have a 20 second timeout

When time mode is initially set to Manual from NTP,
NTP service is disabled and the NTP service is
stopping but not stopped, setting time will return an error.
There are no responses from backend to notify when NTP is stopped.

Date-time bug openbmc/openbmc#3459
https://ibm-systems-power.slack.com/archives/C0Q6TQP5Z/p1616420134178500

Looking to get rid of the 20 sec timeout on the GUI here:
https://github.com/openbmc/webui-vue/blob/master/src/store/modules/Settings/DateTimeStore.js#L49

To do that need to not return until NTP stops or return a task the client (GUI) can watch

I suspect we need some changes here: https://github.com/openbmc/phosphor-time-manager

@gtmills gtmills added this to the A.1.214.11 milestone Oct 18, 2021
@gtmills gtmills added the ReadyForDev Stories ready for development work label Aug 8, 2022
@lxwinspur lxwinspur self-assigned this Aug 16, 2022
@lxwinspur
Copy link

@gtmills @mzipse

Regarding this issue, I pushed a new patch: https://gerrit.openbmc.org/c/openbmc/phosphor-time-manager/+/56584
And Looks like the maintiner is against adding this feature to the timeManager repo, because he think that this logic should be handled where it is called.
But we still did some refactoring to the timeManager repo。

So, What do you think?

@mzipse mzipse added the Migrate-No Do not migrate to Jira label Oct 26, 2022
@gtmills
Copy link
Author

gtmills commented Nov 17, 2022

We discussed this in discord, are you planning anything here @lxwinspur ?

@lxwinspur
Copy link

We discussed this in discord, are you planning anything here @lxwinspur ?

I pushed a commit for this issue: https://gerrit.openbmc.org/c/openbmc/phosphor-time-manager/+/56584
But Lei disagreed with this patch, do you have any suggestions? Do we need to change systemd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Migrate-No Do not migrate to Jira ReadyForDev Stories ready for development work
Projects
None yet
Development

No branches or pull requests

5 participants