Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox: remove properties #691

Open
wkeese opened this issue Jan 24, 2017 · 0 comments
Open

Combobox: remove properties #691

wkeese opened this issue Jan 24, 2017 · 0 comments

Comments

@wkeese
Copy link
Member

wkeese commented Jan 24, 2017

I think we can get rid of the hasDropDownArrow and autoFilter properties, in order to remove the combinations of settings we don't want to support or test:

  • hasDropDownArrow=true, minFilterChars=1
  • hasDropDownArrow=false, minFilterChars=0
  • hasDropDown=false, autoFilter=false

Instead define behavior that:

  • minFilterChars=-1: <input> is readonly, and clicking it opens the dropdown with all the choices.
  • minFilterChars=0: Original behavior, where user can open the dropdown at any point, but can also do filtering by typing something in the <input>.
  • minFilterChars >= 1: AKA "autocomplete" mode. Don't show the down arrow icon because we don't want to let the user see all the possible completions. Instead, force user to type n characters before filtering occurs.

... or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant