-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BIP-38 Support #140
Comments
I like this suggestion. Probably will use the bitcoinjs/bip38 library - https://github.com/bitcoinjs/bip38 |
If you do, it seems that from my experience (see cantonbecker/bitcoinpaperwallet#32) that it is also helpful to generate the compressed public key in addition to the uncompressed public key, or else to generate the uncompressed private key (generating the private 5... key not only the K... or L... key). When one sweeps a BIP38 encrypted wallet into a client such as Mycelium or Samurai, the public key that gets imported is the public key from the uncompressed version of the private key. Essentially, applying BIP38 to the 5... address, and then importing into a client, generates the anticipated public key, applying BIP38 to the K/L compressed private key generates a different public address (because you're hashing only half of the EC), so even just exposing the uncompressed private keys would be helpful, so feature request is for the uncompressed private keys please? |
Feature Request: When generating Derived private keys, add the option to derive and then apply a BIP38 passphrase for security. (Obviously this would add rendering time for each key, but would still be faster than performing it incrementally on each key).
The text was updated successfully, but these errors were encountered: