Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Suggestions #24

Open
iampavangandhi opened this issue Jul 19, 2020 · 8 comments
Open

Course Suggestions #24

iampavangandhi opened this issue Jul 19, 2020 · 8 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@iampavangandhi
Copy link
Owner

iampavangandhi commented Jul 19, 2020

Hello @everyone 👋,

You can tell your thoughts and suggestions related to TheNodeCourse here.

Pavan Gandhi (Mentor)

@iampavangandhi iampavangandhi added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Jul 19, 2020
@howdyAnkit
Copy link
Contributor

howdyAnkit commented Jul 29, 2020

Hey, @iampavangandhi

Please check Below the mentioned Automated Bots Below.
it will be the perfect use for our Project.

  • Hound (Automatic Code Review)
  • ImgBot (Automatic Optimizes Image)
  • Codacy (Automated code review)

@iampavangandhi
Copy link
Owner Author

Hey, @howdyAnkit

Thanks for the suggestions we don't need these automated bots in TheNodeCourse Project because I and @vectorrb are the only contributors. We will surely use these bots in TradeByte as it's a team project.

@iampavangandhi iampavangandhi added enhancement New feature or request and removed help wanted Extra attention is needed labels Jul 31, 2020
@ChiragBolakani
Copy link
Contributor

Hey @iampavangandhi I have a course suggestion of having a tutorial of bcrypt in TheNodeCourse as its widely used in hashing the credentials and then using it in storing the data in MongoDB. I would like to work on this as I'm pretty familiar with NodeJs.

@iampavangandhi
Copy link
Owner Author

@ChiragBolakani Yes, you can try. you also have to create a .md file where you explain all about bcrypt and your code in a code folder then add both of them in a folder Auth Topic 6 and add it in the 04 Auth and Database folder

Note: You don't have to do any linking. I will do that myself after merging the PR

@ChiragBolakani
Copy link
Contributor

@iampavangandhi I have started working on it.

@ChiragBolakani
Copy link
Contributor

@iampavangandhi I have completed the task. This is my pull request #38

@iampavangandhi
Copy link
Owner Author

iampavangandhi commented Oct 25, 2020

@ChiragBolakani PR Merged 🎉 Welcome to TheNodeCourse 👍🏻

@ChiragBolakani
Copy link
Contributor

ChiragBolakani commented Nov 1, 2020

@iampavangandhi Please add the hacktoberfest label again to the repo. My pull request was not counted as the repo didn't had hacktoberfest label. The hacktoberfest also has a 14 days review period and the pull request needs to pass that. You may remove the hacktoberfest label after 10 November. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants