Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of console on Windows #234

Open
fkaa opened this issue Jan 5, 2016 · 4 comments
Open

Get rid of console on Windows #234

fkaa opened this issue Jan 5, 2016 · 4 comments

Comments

@fkaa
Copy link
Collaborator

fkaa commented Jan 5, 2016

Currently we don't do anything to the linker flags, so we get both a console and the Iceball window when launching on windows. If we were to get rid of the console it'd be nice to have something like #130 implemented first.

To get rid of the console we must both link to SDL2main and only specify the WINDOWS module in the linker arguments like this:

set(CMAKE_EXE_LINKER_FLAGS  "${CMAKE_EXE_LINKER_FLAGS} -mwindows")
@rakiru
Copy link
Collaborator

rakiru commented Jan 6, 2016

With these args, does it still output to the console if run from it?

@fkaa
Copy link
Collaborator Author

fkaa commented Jan 6, 2016

@rakiru yes, it just hides it when double click on the .exe for example. Unfortunately Visual Studio doesn't have a way to show the output, but I can probably add a option for it to use while devving.

@rakiru
Copy link
Collaborator

rakiru commented Jan 6, 2016

#ifdef _DEBUG or w/e I guess.

@iamgreaser
Copy link
Owner

Considering that the window disappears when any code crashes and you have to run from the commandline to see the error anyway, I'm OK with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants