Add 30s timeout for controller spawners #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the latest ros_controllers release has a default timeout that's too short to allow Gazebo to properly start up, resulting in the diff drive controller & joint state broadcaster to time-out rather than starting up. Adding an explicit timeout appears to work around this issue.
alsora
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Add 30s timeout for controller spawners It looks like the latest ros_controllers release has a default timeout that's too short to allow Gazebo to properly start up, resulting in the diff drive controller & joint state broadcaster to time-out rather than starting up. Adding an explicit timeout appears to work around this issue. * copy & paste error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like the latest ros_controllers release has a default timeout that's too short to allow Gazebo to properly start up, resulting in the diff drive controller & joint state broadcaster to time-out rather than starting up. Adding an explicit timeout appears to work around this issue.
Type of change
How Has This Been Tested?
Tested locally on Jazzy.
Result before patch: diff drive controller & joint state broadcaster show timeout errors after 0.3s.
Result after patch: both controllers start normally, even when loading a complex world on a RAM-constrained laptop.
Checklist