Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write rpaths when installing #34

Merged
merged 1 commit into from
May 2, 2024
Merged

Write rpaths when installing #34

merged 1 commit into from
May 2, 2024

Conversation

jmcarcell
Copy link
Contributor

BEGINRELEASENOTES

ENDRELEASENOTES

Before #32 and after for non-Apple platforms are not equivalent because before rpaths are being written and after they are not. I believe the default value of CMAKE_SKIP_INSTALL_RPATH is FALSE. With this change I can see rpaths are being written again.

tmadlener
tmadlener approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably fix the nightlies again, right?

@tmadlener tmadlener merged commit 5220013 into iLCSoft:master May 2, 2024
4 checks passed
@andresailer
Copy link
Contributor

Let's see: https://gitlab.cern.ch/key4hep/k4-deploy/-/pipelines/7319643

@tmadlener
Copy link
Contributor

tmadlener commented May 2, 2024 •
edited
Loading

This does not yet fix the issue for me locally. I will keep looking

EDIT: If you do stuff consistently, it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmcarcell @andresailer @tmadlener