Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential indexing issue and remove CentOS7 from CI workflows #47

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jun 19, 2024

BEGINRELEASENOTES

  • Fix a potential indexing issue in WeightedPoints3D
  • Remove no longer supported CentOS7 from Key4hep workflows

ENDRELEASENOTES

The indexing issue does look a bit worse than it actually is, since it effectively cancels itself; Quoting from some email exchange with @MikaelBerggren

It's a bit of a mess with this reversed order of matrix indices in C w.r.t. mathematical notation. Writing down what should be done (cf. the two out-commented fortran lines) with Einstein notation (sum over repeated indices) and using that both _theta_phi_cov and _xyz_cov are symmetric, and the same swap of the correct order of indices are done on lines 892 and 900 (effectively cancelling the error), the minimal correct fix is to swap the loop-bounds (3 -> 2 on line 888, 2->3 on line 889).

@tmadlener tmadlener changed the title Remove no longer supported CentOS7 from Key4hep workflows Fix potential indexing issue and remove CentOS7 from CI workflows Aug 26, 2024
@tmadlener tmadlener merged commit e473dcf into iLCSoft:master Aug 26, 2024
6 checks passed
@tmadlener tmadlener deleted the rm-centos7 branch August 26, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant