Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ConformalTracking to behave less diruptively on encountering too many tracks #62

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

Zehvogel
Copy link
Contributor

@Zehvogel Zehvogel commented Nov 8, 2023

Before this, ConformalTracking would throw a SkipEventException resulting in further Marlin processors down the line to not be executed. However, when using Marlin processors from Gaudi with the k4MarlinWrapper, the expected behaviour of a failing processors is to (optionally warn and) emit its usual output collections. Otherwise PodioOutput crashes in the end...

BEGINRELEASENOTES

  • Emit an error message and skip further steps when too many tracks are created instead of throwing a SkipEventException

ENDRELEASENOTES

I tested the changes locally and they solved key4hep/k4MarlinWrapper#158 for me. The track pulss also did not change more than they do from run to run anyway so I hope I did not break anything.

@andresailer
Copy link
Contributor

Could you undo the unrelated whitespace changes?

Do you not have a global gitignore file?

Does this now potentially leave a partially reconstructed event or will no tracks be created?

@Zehvogel
Copy link
Contributor Author

Zehvogel commented Nov 8, 2023

It will reconstruct as many tracks as far as it can. For the event in the linked issue it reconstructs 1 track (the correct one from the single pion) and results in a useful PFO with correct energy further down the chain.

Copy link
Contributor

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it might give some badly reconstructed event, instead of no reconstructed object. But if needed one should be able to filter this out.

Thanks for for the changes!

@andresailer andresailer merged commit bbf5e9f into iLCSoft:master Nov 8, 2023
4 checks passed
@Zehvogel Zehvogel deleted the no-except branch November 10, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants