Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Weight Parameter Used for Loss Calculation #18

Open
elTorado opened this issue Mar 14, 2024 · 0 comments
Open

Incorrect Weight Parameter Used for Loss Calculation #18

elTorado opened this issue Mar 14, 2024 · 0 comments

Comments

@elTorado
Copy link

File: train.py

Issue:
Incorrect weight parameter options['beta'] used in loss calculations.
Lines affected: 93 and 117.

Expected:
Use options['--weight-pl'] for weight in the loss calculations, as it's intended for center loss, not options['beta'], which is for entropy loss.

Details:

  • Line 93: generator_loss calculation.
  • Line 117: total_loss calculation.

Suggested Fix:
Replace options['beta'] with options['--weight-pl'] in the affected lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant