Feature/improve drive id retrieval #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould be hardcoded for Hypriot images, which also works for official Ubuntu 20.04 RPI images. However, some images like Ubuntu 18.04 of rock64 create the boot disk as '/dev/disk2s6')
…d be hardcoded for Hypriot images, but not for other images)
|
@kremerol Thank you for the contribution. Some tests fail on CircleCI if you could have a look. |
|
@StefanScherer - done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using hypriot flash utility to flash hypriot images, but also other other images, for which the 'FAT' partition is not always the first one: for instance, the disk image for the rock-64 arm device (https://github.com/ayufan-rock64/linux-build/releases/download/0.8.3/bionic-minimal-rock64-0.8.3-1141-arm64.img.xz) has 7 partitions, and the FAT partition is number 6.
Therefore, I have improved the way to retrieve this partition id (I search for the first MSDOS partition). I did some successful test on linux and on mac (but of course, not with every possible situation).
I will be happy to see this code in a next official hypriot/flash release.