Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid export format descriptions cropping #6651

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Avoid export format descriptions cropping #6651

merged 2 commits into from
Nov 5, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Nov 4, 2024

While testing some of the latest changes in the Select component in client, I noticed the description of export formats could be cropped if the sidebar is too small.

This PR ensures descriptions wrap multiple lines if needed.

Before:

image

After:

image

I also took the opportunity to replace the deprecated right prop with the new alignListbox="right".

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (5627ba9) to head (1c71ea7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6651   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         270      270           
  Lines       10172    10172           
  Branches     2418     2418           
=======================================
  Hits        10114    10114           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit e02b5f3 into main Nov 5, 2024
4 checks passed
@acelaya acelaya deleted the export-desc-crop branch November 5, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants