Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6475] Whenever an iframe changes location Hypothesis needs to be injected again #6476

Closed
wants to merge 1 commit into from

Conversation

jwgmeligmeyling
Copy link

When enabling annotations on an iframe with the enable-annotation attribute, it appears the client is only injected once. This leads to issues when the frame navigates to another page. I haven't checked whether the issue exists for all types of navigation (for example if it matters if the parent or the frame itself is causing the navigation). In this particular case the frame was initialised with about:blank.

I have found that reattaching the frame on the load event on the frame solves the issue. I am open for better suggestions fixing this.

Fixes #6475

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Used by https://github.com/probot/stale to label stale issues and pull requests before closing them label Aug 27, 2024
@github-actions github-actions bot closed this Sep 2, 2024
@robertknight robertknight reopened this Sep 2, 2024
@github-actions github-actions bot closed this Sep 8, 2024
@robertknight robertknight reopened this Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.44%. Comparing base (f4e5e98) to head (9e3cc94).
Report is 163 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6476      +/-   ##
==========================================
+ Coverage   99.43%   99.44%   +0.01%     
==========================================
  Files         271      270       -1     
  Lines       10238    10444     +206     
  Branches     2425     2489      +64     
==========================================
+ Hits        10180    10386     +206     
  Misses         58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot closed this Sep 14, 2024
@robertknight robertknight reopened this Sep 14, 2024
@github-actions github-actions bot closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used by https://github.com/probot/stale to label stale issues and pull requests before closing them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whenever an iframe changes location Hypothesis needs to be injected again
2 participants