Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adder not fully visible due to z-index miscalculation #6431

Open
robertknight opened this issue Jun 28, 2024 · 0 comments
Open

Adder not fully visible due to z-index miscalculation #6431

robertknight opened this issue Jun 28, 2024 · 0 comments

Comments

@robertknight
Copy link
Member

Originally reported in Slack

Steps to reproduce:

  1. Go to https://immer.app/en/social-reading/
  2. Activate the client
  3. Select text

Result:

The adder appears but is not fully visible and does nothing when clicked:

Adder partially visible

Notes:

The <hypothesis-adder> element is given a z-index of 1. The document's main <article> however has a z-index of 2, so it gets rendered above the adder. Manually increasing the z-index of the <hypothesis-adder> makes it fully visible and interactive.

We have logic (Adder._findZIndex) to find the z-index of the content underneath the adder and choose a higher value. However it looks like it fails to take into account the z-index of ancestor elements of the points used to compute the index.

Related issues: #5622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant