Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] tooltip position is not correct when first rendered #601

Closed
tyn1998 opened this issue Mar 12, 2023 · 1 comment · Fixed by #795
Closed

[Bug] tooltip position is not correct when first rendered #601

tyn1998 opened this issue Mar 12, 2023 · 1 comment · Fixed by #795
Labels
kind/bug Category issues or prs related to bug. waiting for repliers
Milestone

Comments

@tyn1998
Copy link
Member

tyn1998 commented Mar 12, 2023

Version

1.9.0 (has not been released)

Current Behavior

Pay attention to the difference of caret positions before and after the tab switch(navigated back by browser history) when watching the following screen cast:

2023-03-12.12.46.09.mov

The positions were corrected after navigation because "go back" triggered a restoration turbo:visit where we added code for rerender logic. This issue should also exist in previous versions but it was not exposed because in previous version we also put data fetch process in xxxView.tsx so after data was fetched another setState() was triggered then the component rerendered again, which hid the issue from our eyes.

Expected Behavior

should be rendered in correct position as always.

Environment

- OS: whatever
- Browser: whatever

Any additional comments?

The issue is related to dynamic content of ReactTooltip v4. It seems v5 has a better solution, so we may have a try on v5.

@tyn1998
Copy link
Member Author

tyn1998 commented Apr 29, 2024

This issue can be closed by #795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug. waiting for repliers
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant