Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scree plot includes too many components #117

Open
thomasaarholt opened this issue Apr 5, 2017 · 3 comments
Open

Scree plot includes too many components #117

thomasaarholt opened this issue Apr 5, 2017 · 3 comments

Comments

@thomasaarholt
Copy link
Contributor

The scree plot produced from Decomposition Model has no way of limiting the number of components, which makes it difficult to choose the right number.
Previously the limit used to be 30 (I think?), but the new code is set to be equal to the number of channels in the signal.

@vidartf
Copy link
Member

vidartf commented Apr 5, 2017

For reference, the hyperspy change is hyperspy/hyperspy#1359.

Any suggestions for how to solve this best? The simplest approach is of course to hardcode 50 in the UI code to replicate the old behavior.

@jat255
Copy link
Member

jat255 commented Apr 5, 2017 via email

@thomasaarholt
Copy link
Contributor Author

Hard code it for now, as you can only use the standard PCA algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants