Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decodeDynamicStructElements NPE fix #1972

Conversation

lzgh0102
Copy link
Contributor

What does this PR do?

fix decodeDynamicStructElements NPE
lower version codegen does not generate @parameterized annotation when use DynamicArray parameter, which will cause the error as below that confuse people
image

Where should the reviewer start?

use the test case: org.web3j.abi.FunctionReturnDecoderTest#testDecodeDynamicStruct3
remove the Annotation can see the case
image

Why is it needed?

(#1726 (comment)

@NickSneo
Copy link
Contributor

NickSneo commented Oct 13, 2023

Seems the build is failing in pipeline

@lzgh0102 lzgh0102 closed this Oct 16, 2023
@lzgh0102 lzgh0102 deleted the fix-dynamicArray-decode-null-pointer branch October 16, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants