Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade labels of cello tools and config files(orderer.yaml and core.yaml) to HLFv2.5.9 #632

Merged
merged 7 commits into from
Sep 26, 2024

Conversation

YoungHypo
Copy link
Collaborator

@YoungHypo YoungHypo commented Sep 6, 2024

1.Set FABRIC_VERSION in src/api-engine/api/config.py to replace the "2.2.0" tags for configtxgen, configtxlator, cryptogen, chaincode, and channel.
2.Updated core.yaml and orderer.yaml to version 2.5.9

@YoungHypo YoungHypo requested a review from a team September 6, 2024 16:21
@@ -4,13 +4,13 @@
"values": [
{
"key": "apiServer",
"value": "http://127.0.0.1:$API_ENGINE_SERVICE_PORT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These variable will read value from env.

"description": "",
"enabled": true
},
{
"key": "webRoot",
"value": "$API_ENGINE_WEBROOT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@@ -8,7 +8,7 @@
class ConfigTxGen:
"""Class represents cryptotxgen."""

def __init__(self, network, filepath=CELLO_HOME, configtxgen=FABRIC_TOOL, version="2.2.0"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use some variables, instead of fixed number?
This way is more convenient to update in future.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my latest commit, I've used FABRIC_VERSION in <src/api-engine/api/config.py> to control version number.

@yeasy yeasy merged commit 77f7994 into hyperledger:main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants