Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: backend interface #19

Merged
merged 2 commits into from
May 10, 2024

Conversation

dbluhm
Copy link
Member

@dbluhm dbluhm commented May 7, 2024

The interface was a bit inconsistent and loose. These refactors just tighten things up a bit.

@dbluhm dbluhm marked this pull request as ready for review May 7, 2024 01:25
The interface was a bit inconsistent and loose. These refactors just
tighten things up a bit.

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm dbluhm force-pushed the refactor/backend-interface branch from 1ac1996 to 883ae6d Compare May 7, 2024 01:26
mepeltier
mepeltier previously approved these changes May 7, 2024
Copy link
Contributor

@mepeltier mepeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
Copy link
Member Author

dbluhm commented May 10, 2024

@mepeltier I tested a bit more thoroughly and corrected a few things. Should be ready for real this time!

Copy link
Contributor

@mepeltier mepeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dbluhm dbluhm merged commit d5d0fd2 into hyperledger:main May 10, 2024
2 checks passed
@dbluhm dbluhm deleted the refactor/backend-interface branch May 10, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants