Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --release flag to iroha_wasm_builder #5202

Open
mversic opened this issue Oct 29, 2024 · 2 comments · May be fixed by #5209
Open

Add --release flag to iroha_wasm_builder #5202

mversic opened this issue Oct 29, 2024 · 2 comments · May be fixed by #5209
Assignees

Comments

@mversic
Copy link
Contributor

mversic commented Oct 29, 2024

Whenever we're using iroha_wasm_builder we're invoking cargo with --release. This should not be the default. The default should be to produce debug build. Optionally it should be possible to build with --release. This is how cargo does it and is least confusing. It is also the case that most if not all of the wasm should be built as debug (we can discuss the scope).

@aoyako aoyako linked a pull request Oct 30, 2024 that will close this issue
4 tasks
@0x009922
Copy link
Contributor

0x009922 commented Nov 1, 2024

The default should be to produce debug build.

That would not align with the "main" known WASM tool in Rust ecosystem, i.e. wasm_pack: it uses --release by default.

And I can understand the rationale that if you develop a WASM for web (or for Iroha) you might want it in release mode in most cases.

@mversic
Copy link
Contributor Author

mversic commented Nov 4, 2024

That would not align with the "main" known WASM tool in Rust ecosystem, i.e. wasm_pack: it uses --release by default.

And I can understand the rationale that if you develop a WASM for web (or for Iroha) you might want it in release mode in most cases.

I see. I'm fine either way whichever will eliminate most of user questions. In this case since there is no way of running smart contracts without submitting them to iroha, --release as the default could be more reasonable.

The thing that I'm more interested in is that we get the possibility of building with debug/test profiles and that we consider building with those profiles in the CI. At least to get stack traces in wasm

@aoyako aoyako self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants