[feature] #306: Validate links post-build #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
0x009922
requested review from
outoftardis,
WRRicht3r,
6r1d and
appetrosyan
as code owners
WRRicht3r
requested changes
Sep 13, 2023
Co-authored-by: William Richter <[email protected]> Signed-off-by: 0x009922 <[email protected]>
Co-authored-by: William Richter <[email protected]> Signed-off-by: 0x009922 <[email protected]>
|
@WRRicht3r, this PR is focused on functional changes and related documentation fixes. While I appreciate your suggestions on doc strings, they are technically outside the scope of this PR. I have included them this time, but in the future, I would prefer to keep PRs more granular. |
WRRicht3r
approved these changes
Sep 14, 2023
6r1d
pushed a commit
to 6r1d/iroha-2-docs
that referenced
this pull request
Jan 8, 2024
…er-iroha#405) * [feature]: implement links validation, without pub path Signed-off-by: Dmitry Balashov <[email protected]> * [feature]: resolve links with pub path Signed-off-by: Dmitry Balashov <[email protected]> * [feature]: refine reporting Signed-off-by: Dmitry Balashov <[email protected]> * [ci]: validate links Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: chores Signed-off-by: Dmitry Balashov <[email protected]> * [chore]: fix format Signed-off-by: Dmitry Balashov <[email protected]> * [ci]: workaround with FORCE_COLOR Signed-off-by: Dmitry Balashov <[email protected]> * [ci]: use FORCE_COLOR in gh-pages-deploy too Signed-off-by: Dmitry Balashov <[email protected]> * [docs]: fix broken links Signed-off-by: Dmitry Balashov <[email protected]> * Apply suggestions from code review Co-authored-by: William Richter <[email protected]> Signed-off-by: 0x009922 <[email protected]> * Update src/guide/advanced/running-iroha-on-bare-metal.md Co-authored-by: William Richter <[email protected]> Signed-off-by: 0x009922 <[email protected]> --------- Signed-off-by: Dmitry Balashov <[email protected]> Signed-off-by: 0x009922 <[email protected]> Co-authored-by: William Richter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #306