Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OORT Devnet (Testnet) #100

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Add OORT Devnet (Testnet) #100

wants to merge 9 commits into from
+76 −0

Conversation

molecula451
Copy link

Description

Add OORT DevNet (Testnet)

Backward compatibility

Testing

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 30a026a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@molecula451 molecula451 changed the title Add OORT Devnet (Tesnet) Add OORT Devnet (Testnet) Jul 11, 2024
@molecula451 molecula451 marked this pull request as draft July 11, 2024 22:01
@molecula451 molecula451 marked this pull request as draft July 11, 2024 22:01
@molecula451 molecula451 marked this pull request as ready for review July 11, 2024 22:38
jmrossy
jmrossy reviewed Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just a few things to fix

chains/oortdevnet/logo.svg Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the extra whitespace around this logo and also minify it? These online tools can help:
https://jsfiddle.net/knLbjc9a/4/
https://jakearchibald.github.io/svgomg/

chains/oortdevnet/metadata.yaml
Comment on lines +11 to +12
deployer:
email: [email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including this. Would you mind also setting the name field here?

chains/oortdevnet/metadata.yaml Outdated
blockExplorers:
family: other
name: OORT Dev Explorer
url: https://dev-scan.oortech.com
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an apiUrl will also be required here

@molecula451 molecula451 marked this pull request as draft July 16, 2024 23:36
@jmrossy
Copy link
Collaborator

jmrossy commented Jul 24, 2024

@molecula451 I see this PR is still in Draft mode. Was that intentional or would you like me to take another look?

@molecula451
Copy link
Author

hey @jmrossy this was intentinal, re-opening this ASAP, im checking somethings on the metadata, re-tagging you

@jmrossy
Copy link
Collaborator

jmrossy commented Jul 24, 2024

@molecula451 no rush, take your time :)
I'll keep an eye out for updates here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrossy jmrossy jmrossy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@molecula451 @jmrossy