Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding retry and timeout wrappers to fetch calls #77

Open
jmrossy opened this issue Jun 27, 2024 · 0 comments
Open

Consider adding retry and timeout wrappers to fetch calls #77

jmrossy opened this issue Jun 27, 2024 · 0 comments
Labels
enhancement New feature or request registry

Comments

@jmrossy
Copy link
Collaborator

jmrossy commented Jun 27, 2024

The GithubRegistry makes fetches via the native fetch API here: https://github.com/hyperlane-xyz/hyperlane-registry/blob/sprint27/src/registry/GithubRegistry.ts#L211

To compensate for flaky connections, it may make sense to add some retry logic for failures.
The downside is that if the problem is legitimate (e.g. bad URL), it would burn through an IP's quota faster.

Some timeout handling around the fetch would also be a good idea.

Note, #29 would help mitigate connectivity issues entirely so I'd recommend we start there.

@jmrossy jmrossy added enhancement New feature or request registry labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request registry
Projects
None yet
Development

No branches or pull requests

1 participant