Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVAT] Refactor oracle configs #2780

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Conversation

zhiltsov-max
Copy link
Collaborator

Issue tracking

Context behind the change

Depends on #2720

This PR updates settings for Exchange Oracle and Recording Oracle.

  • Refactored environment variable access
  • Removed extra cvat_ prefix in CVAT-related settings. Class name is clear enough
  • Synchronized .env.template files (TODO: need to use them to load default values in future)
  • Removed several deprecated settings
    • [EO] RETRIEVE_ANNOTATIONS_INT
  • Removed several unused settings
    • [EO] TRACK_COMPLETED_PROJECTS_CHUNK_SIZE (might be needed in future)
    • [EO] TRACK_COMPLETED_TASKS_CHUNK_SIZE (might be needed in future)
    • [EO] CVAT_JOB_OVERLAP
    • [EO, RO] STORAGE_REGION
    • [RO] EXCHANGE_ORACLE_STORAGE_REGION
    • [RO] DEFAULT_POINT_VALIDITY_RELATIVE_RADIUS
    • [RO] DEFAULT_OKS_SIGMA
  • Added missing settings
    • [EO] TRACK_ESCROW_VALIDATIONS_INT
  • Deprecated some variables
    • [RO] UNVERIFIABLE_ASSIGNMENTS_THRESHOLD
  • Renamed some of the internal identifiers for variables

How has this been tested?

Release plan

Potential risks; What to monitor; Rollback plan

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 3:37pm
human-dashboard-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 3:37pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 3:37pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 3:37pm

@zhiltsov-max zhiltsov-max changed the title [CVAT] [Dependent] Refactor oracle configs [CVAT] Refactor oracle configs Nov 14, 2024
@zhiltsov-max zhiltsov-max changed the base branch from mk/update_cvat_oracles to develop November 14, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant