Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Human App] Convert all chainIds values ​​to type ChainId #2725

Closed
eugenvoronov opened this issue Oct 30, 2024 · 0 comments
Closed

[Human App] Convert all chainIds values ​​to type ChainId #2725

eugenvoronov opened this issue Oct 30, 2024 · 0 comments
Assignees

Comments

@eugenvoronov
Copy link
Contributor

eugenvoronov commented Oct 30, 2024

Description
Cast chainId values from string to ChainId type in the Human App for better type consistency.

Motivation
Using ChainId type improves code readability and reduces errors related to type mismatches.

Implementation details

  • Update chainIdsEnabled method in environment-config.service.ts to return ChainId[].
  • Replace string chain IDs with ChainId across the app.
  • Add additional chainId parameter to getExchangeOracleUrlByAddress and getJobTypesByAddress in KvStoreGateway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants