Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove <abbr> from Altis link #673

Open
2 tasks
robindevitt opened this issue Sep 1, 2022 · 0 comments
Open
2 tasks

Remove <abbr> from Altis link #673

robindevitt opened this issue Sep 1, 2022 · 0 comments
Labels
bug Existing functionality isn't behaving as expected

Comments

@robindevitt
Copy link
Contributor

Originally reported in humanmade/altis-cms#629

<abbr> is not an allowed element inside a link, see MDN on links

Code referenced:

$envs = [
'local' => esc_html_x( 'local', 'Server environment type', 'altis' ),
'development' => sprintf( '<abbr title="%s">%s</abbr>',
esc_attr_x( 'development', 'Server environment type - full form', 'altis' ),
esc_html_x( 'dev', 'Server environment type - abbreviated', 'altis' )
),
'staging' => esc_html_x( 'staging', 'Server environment type', 'altis' ),
'production' => sprintf( '<abbr title="%s">%s</abbr>',
esc_attr_x( 'production', 'Server environment type - full form', 'altis' ),
esc_html_x( 'prod', 'Server environment type - abbreviated', 'altis' )
),
];

Acceptance criteria:

  • Remove the <abbr> element from the link being displayed.
  • have the appropriate link title matching the environment.
@robindevitt robindevitt added the bug Existing functionality isn't behaving as expected label Sep 1, 2022
@robindevitt robindevitt transferred this issue from humanmade/altis-cms Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Development

No branches or pull requests

1 participant