Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect names for usage blenderbot for causallm #1887

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

eaidova
Copy link
Contributor

@eaidova eaidova commented Jun 3, 2024

What does this PR do?

in general case, number of encoder and decoder layers in seq2seq models like blenderbot, m2m, bart can be different from encoder.
As example blenderbot-3b - https://huggingface.co/facebook/blenderbot-3B/blob/main/config.json
If we use these models for causal lm case, where used only decoder, output names can be incorrect due to unequal number of layers in decoder and encoder (that is used for preparing inputs if model has past_key_values).

This PR fixes this issue

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@fxmarty, @echarlaix, @JingyaHuang, @michaelbenayoun

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@michaelbenayoun
Copy link
Member

Can you run make style and push please. It is necessary to format the code.

@eaidova
Copy link
Contributor Author

eaidova commented Jun 25, 2024

@fxmarty @michaelbenayoun @echarlaix is it possible to merge these changes? We are blocked to convert and optimize this model on openvino side, thanks!

@fxmarty fxmarty merged commit d82d4c6 into huggingface:main Jul 1, 2024
41 of 45 checks passed
@fxmarty
Copy link
Contributor

fxmarty commented Jul 1, 2024

@eaidova Done thank you, apology for the delay!

@eaidova eaidova deleted the ea/fix_blenderbot branch July 1, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants