-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Utils CI #1867
Fix Utils CI #1867
Conversation
b3db829
to
d50e1f9
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
.github/workflows/test_utils.yml
Outdated
runs-on: ${{ matrix.os }} | ||
steps: | ||
- name: Free Disk Space (Ubuntu) | ||
uses: jlumbroso/free-disk-space@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also do you think we can reduce the model / dataset size used during testing https://github.com/huggingface/optimum/blob/main/tests/utils/test_dummpy_input_generators.py#L38 ? (using tiny random models for example)
.github/workflows/test_utils.yml
Outdated
- name: Free Disk Space (Ubuntu) | ||
uses: jlumbroso/free-disk-space@main | ||
if: matrix.os == 'ubuntu-20.04' | ||
with: | ||
tool-cache: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/utils/test_task_processors.py
Outdated
@@ -157,11 +160,15 @@ def _test_load_dataset( | |||
path, | |||
data_keys=data_keys, | |||
only_keep_necessary_columns=only_keep_necessary_columns, | |||
load_smallest_split=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
still fails after two datasets 🥲 |
reducing the number of samples works (it was the tensors written to disk memory and not the dataset splits) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ilyas for the fixes
What does this PR do?
Fixes tasks processor ci
Before submitting
Who can review?