Initialize AcceleratorConfig in optimum TrainingArgs. #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JingyaHuang
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Thanks @AdamLouly, the changes look good to me.
Just the code quality CI is failing, could you install the styling tool with
pip install .[quality] and then fix the style with make style? Thx!
Done! |
young-developer
pushed a commit
to young-developer/optimum
that referenced
this pull request
May 10, 2024
* add accelerator config * make style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Transformers Introduced AccelerateConfigure dataclass huggingface/transformers#28664
So we need to initialize it in Optimum Training Args.
Check this issue for reference: #1749