Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump transformers and optimum version #615

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented May 30, 2024

What does this PR do?

This bumps transformers to 4.41.1 and optimum to 1.20.0.

This also adds the new transformers "stop strings" generation feature to NeuronModelForCausalLM, allowing to support the "stop_sequences" parameter in NeuronX TGI.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , tho we might need @michaelbenayoun to confirm that bumping trfrs version won't break the training.

@@ -13,9 +13,9 @@


INSTALL_REQUIRES = [
"transformers == 4.40.2",
"transformers == 4.41.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you test before the release (with perhaps test pypi) that pip install optimum[neuronx] installs the correct version of optimum and optimum-neuron? thx

@dacorvo
Copy link
Collaborator Author

dacorvo commented May 30, 2024

All tests are green except distributed training which was already failing anyway (latest builds were cancelled after several hours).

@dacorvo dacorvo marked this pull request as ready for review May 30, 2024 12:20
@dacorvo dacorvo merged commit 5e772d7 into main May 30, 2024
10 of 12 checks passed
@dacorvo dacorvo deleted the bump_transformers_optimum branch May 30, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants