Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PyTorch to 2.1 #502

Merged
merged 28 commits into from
Apr 12, 2024
Merged

Bump PyTorch to 2.1 #502

merged 28 commits into from
Apr 12, 2024

Conversation

JingyaHuang
Copy link
Collaborator

@JingyaHuang JingyaHuang commented Mar 4, 2024

What does this PR do?

Fixes #486

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@JingyaHuang JingyaHuang changed the title Bump PyTorch to 2.1 [WIP] Bump PyTorch to 2.1 Mar 4, 2024
@JingyaHuang
Copy link
Collaborator Author

JingyaHuang commented Mar 4, 2024

[Non-LLM INF Tests]

tests/cli/test_export_cli.py ...........                                                                                               [  2%]
tests/exporters/test_export.py ........................................................................................... [ 16%]
.......................................................................................................................... [ 33%]
............................................................                                                                                                               [ 42%]
tests/inference/test_modeling.py F........................................................................................ [ 65%]
.......................................................................................................................... [ 83%]
..............................                                                                                                                                             [ 87%]
tests/inference/test_stable_diffusion_pipeline.py ..........                                                                                                               [ 88%]

1 test failed since weight neff separation is not supported for torch_neuronx for PyTorch 2.1.2 in Neuron SDK 2.17.

* Log

FAILED tests/inference/test_modeling.py::NeuronModelIntegrationTest::test_decouple_weights_neff_and_replace_weight - AttributeError: 'RecursiveScriptModule' object has no attribute 'weights'

replace_weights is not yet supported by neuron SDK 2.17 for PyTorch 2.*, will skip the test for now.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@HuggingFaceDocBuilderDev

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

@michaelbenayoun michaelbenayoun changed the title [WIP] Bump PyTorch to 2.1 Bump PyTorch to 2.1 Apr 12, 2024
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this.

@JingyaHuang JingyaHuang merged commit f936089 into main Apr 12, 2024
12 of 14 checks passed
@JingyaHuang JingyaHuang deleted the bump-to-torch2 branch April 12, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PyTorch 2.1
4 participants