Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API change to be compatible to Optimum #421

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

JingyaHuang
Copy link
Collaborator

DO NOT MERGE until a new Optimum release.

Export API name change according to changes in Optimum main repo

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@JingyaHuang JingyaHuang marked this pull request as ready for review January 19, 2024 21:12
@JingyaHuang JingyaHuang changed the title [DO NOT MERGE] API change to be compatible to Optimum API change to be compatible to Optimum Jan 19, 2024
Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new name makes much more sense. Thanks for the pull-request !

@JingyaHuang JingyaHuang merged commit ff293f0 into main Jan 22, 2024
6 of 8 checks passed
@JingyaHuang JingyaHuang deleted the optimum_api_change_for_export branch January 22, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants