Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation on tensor parallelism #339

Merged
merged 20 commits into from
Nov 23, 2023
Merged

Documentation on tensor parallelism #339

merged 20 commits into from
Nov 23, 2023

Conversation

michaelbenayoun
Copy link
Member

@michaelbenayoun michaelbenayoun commented Nov 20, 2023 •
edited
Loading

As per title.

Closes: #334

@michaelbenayoun michaelbenayoun mentioned this pull request Nov 20, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

dacorvo
dacorvo requested changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this very useful documentation. Just a few typos that should be easily fixed and some nits.

docs/source/_toctree.yml Outdated Show resolved Hide resolved
docs/source/guides/distributed_training.mdx Outdated Show resolved Hide resolved
docs/source/guides/distributed_training.mdx Show resolved Hide resolved
docs/source/guides/distributed_training.mdx Outdated Show resolved Hide resolved
docs/source/guides/distributed_training.mdx Outdated Show resolved Hide resolved
dacorvo
dacorvo reviewed Nov 22, 2023
View reviewed changes
docs/source/_toctree.yml Outdated Show resolved Hide resolved
JingyaHuang
JingyaHuang approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding the doc, I just left some minor nits.

docs/source/package_reference/distributed.mdx Outdated Show resolved Hide resolved
docs/source/guides/distributed_training.mdx Outdated Show resolved Hide resolved
docs/source/guides/distributed_training.mdx Outdated Show resolved Hide resolved
docs/source/guides/distributed_training.mdx Outdated Show resolved Hide resolved
docs/source/guides/distributed_training.mdx Outdated Show resolved Hide resolved
docs/source/guides/distributed_training.mdx Outdated Show resolved Hide resolved
@michaelbenayoun michaelbenayoun merged commit f31ea9b into main Nov 23, 2023
6 of 7 checks passed
@michaelbenayoun michaelbenayoun deleted the tp_documentation branch November 23, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacorvo dacorvo dacorvo approved these changes

@JingyaHuang JingyaHuang JingyaHuang approved these changes

@philschmid philschmid Awaiting requested review from philschmid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What does run_qa.py use tensor or data parallelism?
4 participants
@michaelbenayoun @HuggingFaceDocBuilderDev @dacorvo @JingyaHuang